Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about running the documentation site #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshuataylor
Copy link
Contributor

Notes about how to install pandoc and scdoc.

@Consolatis
Copy link
Member

Consolatis commented Apr 2, 2023

Thanks for the PR. Small review below:

Suggest marking step 2 as optional and adding another optional step along the line of

  • Preview deploy/index.html in a browser

@johanmalm
Copy link
Contributor

Should we make it clear that you don’t actually have to build the site to contribute (i.e. pandoc is only required if you want to view the generated html before committing).

The site will auto build on push.

For big changes it will make sense to view it first, but I wouldn’t want anyone put off from contributing by thinking they’ve got to install pandoc (which is big on some distorts),

@Consolatis
Copy link
Member

Agree, just modifying something in src/, creating a commit and sending the PR is enough to improve the website.
Everything else is just to verify locally that the results are as intended before sending the PR.

@johanmalm
Copy link
Contributor

johanmalm commented Apr 2, 2023

Two suggestions for improvement (I can implement if nobody else feels like it - so just writing here for discussion):

  • Take an optional argument to only build one file. This would save building all src/*.md + man pages just to check that modified markdown page(s) look okay.
  • Return early (with a helpful message) in the two build-site functions if pandoc and scdoc are not available.

Can use a function like this:

is_installed () {
  type "$1" >/dev/null 2>&1
}

type is better than which. Can't remember why though 😄

@Consolatis
Copy link
Member

Consolatis commented Apr 2, 2023

Sounds good to me. There is also command -v "$1" but I don't remember the benefits of command vs type either. I think which had the issue of not detecting shell aliases but I don't quite remember if that was the only difference right now.

We could also mention that it should now be fine to just use the Github interface for the actual edit / commit, that way its not even required to clone the repo locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants